Repository navigation
fix(dependencies): pin override for semver-regex to 3.1.4 / confirm find-versions compat - #185
Merged
Merged
Conversation
…ind-versions compat
agibson-godaddy
self-requested a review
October 7, 2026 11:34
agibson-godaddy
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
semver-regexto3.1.4, resolving Dependabot's security update that was otherwise stuck on an unpatchablesemver-regex@1.0.0.Details
gulp-imagemin'simagemin-gifsicle→gifsicle→bin-wrapper/bin-buildchain pulls infind-versions@3.2.0, which pinssemver-regex@^2.0.0— a range with no patched release (the fix landed in3.1.4).semver-regexcopy exists in the whole tree, and it isn't a direct dependency here, so a blanket override was safe without anyEOVERRIDEconflict or need for chain-scoping.3.1.4rather than latest (4.0.5):semver-regexwent ESM-only ("type": "module", no CommonJS entry point) starting at4.0.0, which would breakfind-versions'require('semver-regex')call outright.3.1.4is the last release still on the stable CommonJSmodule.exports = () => regexshape — identical across2.0.0and3.1.4, confirmed by diffing both versions'index.js.find-versions(the real consumer) still extracts version strings correctly from a sample string against the overriddensemver-regex.semver-regex: alert 13 (high, CVE-2021-3795, patched at3.1.3) and alert 17 (low, CVE-2021-43307, patched at3.1.4) —3.1.4clears both and they should auto-resolve once this merges.QA
Steps
0semver-regexcopy in the tree, resolved to the patched version:find node_modules -type d -iname semver-regex node -p "require('./node_modules/semver-regex/package.json').version"find-versions(the real consumer) still extracts version strings correctly against the overriddensemver-regex:Before merge
npm test) still passes.🤖 Generated with Claude Code