Repository navigation
fix(dependencies): pin override for http-cache-semantics to 4.3.0 / confirm cacheable-request & got compat - #186
Merged
Conversation
…onfirm cacheable-request & got compat
agibson-godaddy
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
http-cache-semanticsto4.3.0, resolving Dependabot's security update that was otherwise stuck on an unpatchablehttp-cache-semantics@3.8.1.Details
gulp-imagemin'simagemin-gifsicle→gifsicle→bin-wrapper→download→got@8.3.2chain pulls ingot's own internal HTTP-caching layer,cacheable-request@2.1.4, which pinshttp-cache-semantics@3.8.1— a version with no patched release in its line (the fix landed in4.1.1, with a second, separate advisory fixed above4.2.0).http-cache-semanticsisn't a direct dependency here and only one copy exists in the tree, so a blanket override was safe without anyEOVERRIDEconflict.got's caching logic, not somethingdownload/gifsiclecall directly. Diffed theCachePolicyclass between3.8.1and4.3.0: the constructor reads the exact samereq.url/req.headers/res.headers/res.statusshape in both versions, and every methodcacheable-request@2.1.4actually calls (storable,toObject,timeToLive,fromObject,satisfiesWithoutRevalidation,responseHeaders,revalidationHeaders,revalidatedPolicy) exists unchanged in4.3.0.cacheable-requestwith each version forced in isolation — byte-identical response body both times, no errors.http-cache-semantics: alert 19 (high, CVE-2022-25881, patched at4.1.1) and alert 194 (high, CVE-2026-93748, vulnerable through4.2.0) —4.3.0clears both and they should auto-resolve once this merges.QA
Steps
0http-cache-semanticscopy in the tree, resolved to the patched version:node -p "require('./node_modules/http-cache-semantics/package.json').version"cacheable-request(the real consumer, used internally bygot) still issues and completes a request correctly against the overriddenhttp-cache-semantics:Before merge
npm test) still passes.🤖 Generated with Claude Code