Repository navigation
[bot] Merge master/f8e960a1 into rel/dev - #1871
Merged
Merged
Conversation
Publisher calls its output a document, so the evaluator, its test kind and its check names now say document: agentic_document_skill, document_skill.py, Document* classes and document_* scores. The agentic_report_skill test kind is gone: its one dataset has to be migrated for the Document wire names anyway, and the Tavern shim calls the evaluator function, not the kind. The Python names stay for existing callers: report_skill.py re-exports the old names with a DeprecationWarning, and core.agentic keeps the old aliases. The wire names gen-ai sends are unchanged here; the evaluator still reads the report part. jira: LX-3248 risk: low Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The evaluator now reads the names gen-ai sends after the Publisher rename: the document answer part with document_ref and the saved_document_id and base_document_id keys, the draft_document tool and the document_builder skill. A new strict check, document_wire_names, fails a run when any Report name is still on the wire: the report part type or keys, the draft_report or list_report_layouts tool, or the report_builder skill. It reads every turn, and its failure leads the list and names each old name, so a half-switched chain shows which part still sends the old one. A user context with view.report is rejected before the first request, because gen-ai reads view.document. This evaluator fails against a gen-ai without the Document names, so release it only once gen-ai sends them. jira: LX-3248 risk: high Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
feat(gooddata-eval): check that gen-ai sends the Document wire names
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1871 +/- ##
===========================================
+ Coverage 84.48% 84.52% +0.04%
===========================================
Files 334 335 +1
Lines 23673 23743 +70
===========================================
+ Hits 19999 20069 +70
Misses 3674 3674 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to f8e960a (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/38227951577).