Repository navigation
chore(gooddata-api-client): regenerate against staging - #1886
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title accurately identifies regenerated gooddata-api-client artifacts, but it does not mention the primary change: removing MONGODB from data-source type enums. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the types today,
MONGODB hops from lists away.
The schemas match the models’ view,
With other values still in queue.
One carrot later, tests can play.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
=======================================
Coverage 85.09% 85.09%
=======================================
Files 337 337
Lines 24331 24331
=======================================
Hits 20704 20704
Misses 3627 3627 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Full regeneration from the stg11 staging specs with `make api-client STAGING=1`, after the backend removed the MONGODB data source type (gdc-nas #28881). MONGODB is gone from the six data source type enums and the source schemas. The regeneration also brings the client up to the rest of the current backend API: the Publisher document, document template and page template entities, localization, the SAV file analysis surface, and new attribute value types. 162 models are added. The shared 202 response of the export APIs is now generated as GetDocumentExport202ResponseInner instead of GetImageExport202ResponseInner; nothing in the packages imports the old name. gooddata-sdk and gooddata-pandas need no changes: both type-check and pass their tests on py314. jira: F1-2973 risk: high Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jeskepetr
force-pushed
the
PJE/F1-2973
branch
from
October 21, 2026 11:09
0be6758 to
37309a3
Compare
jeskepetr
changed the title
Vojtasii
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full regeneration of
gooddata-api-clientfrom the stg11 staging specs withmake api-client STAGING=1. MongoDB was removed from the backend (gooddata/gdc-nas#28881),and that change is now deployed on stg11, so the regenerated client no longer carries the
MONGODBdata source type. Follows the Drill (#1729) and Greenplum (#1723) removals.This replaces the earlier hand edit of the enums with the generator's output, so the diff
also brings the client up to the rest of the current backend API:
MONGODBremoved from the six data source type enums and the source schemasAnalyzeSavRequest…) and new attribute value types(
HLL,TIMESTAMP_TZ, …)GetDocumentExport202ResponseInnerinstead ofGetImageExport202ResponseInnerNo hand-written code changes. As with any full regeneration, the diff is large
(404 files, +54k/−20k lines), almost all of it generated.
Test Plan
make api-client STAGING=1against stg11 running gdc-nasbd2613c0. The mergedschemas/gooddata-api-client.jsonwas built with jq 1.7.1, so unrelated number literalsare not rewritten.
git grep MONGODBreturns nothinggooddata-sdk:make type-checkpasses;TEST_ENVS=py314 make test: 572 passedgooddata-pandas(consumer):make type-checkpasses;TEST_ENVS=py314 make test:347 passed
Risk
high, as for the previous full regeneration (69269ec). The renamed export response
model breaks code that imports
GetImageExport202ResponseInnerdirectly; nothing in thisrepository does. The
MONGODBremoval itself is breaking only for code that references thatliteral.
JIRA: https://gooddata.atlassian.net/browse/F1-2973
🤖 Generated with Claude Code