Skip to content

feat: update setup_workload_identity script #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidAPierce merged 1 commit into from
Aug 21, 2026
Merged

feat: update setup_workload_identity script #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions scripts/setup_workload_identity.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,13 +347,33 @@ gcloud projects add-iam-policy-binding "${GOOGLE_CLOUD_PROJECT}" \
--member="serviceAccount:${SERVICE_ACCOUNT_EMAIL}" \
--condition=None

# Allow the service account to generate an access tokens (self-impersonation only)
# Allow the service account to generate access tokens (self-impersonation only)
print_info "Granting 'Service Account Token Creator' role to Service Account (self-impersonation)..."

gcloud iam service-accounts add-iam-policy-binding "${SERVICE_ACCOUNT_EMAIL}" \
# Add the self-impersonation binding only if it does not already exist (idempotency guard)
EXISTING_TOKEN_CREATOR_BINDING=$(gcloud iam service-accounts get-iam-policy "${SERVICE_ACCOUNT_EMAIL}" \
--project="${GOOGLE_CLOUD_PROJECT}" \
--flatten="bindings[].members" \
--filter="bindings.members:${SERVICE_ACCOUNT_EMAIL}" \
--format="value(bindings.role)" \
2>/dev/null | grep -Fx "roles/iam.serviceAccountTokenCreator" || true)

if [[ -z "${EXISTING_TOKEN_CREATOR_BINDING}" ]]; then
gcloud iam service-accounts add-iam-policy-binding "${SERVICE_ACCOUNT_EMAIL}" \
--project="${GOOGLE_CLOUD_PROJECT}" \
--role="roles/iam.serviceAccountTokenCreator" \
--member="serviceAccount:${SERVICE_ACCOUNT_EMAIL}"
fi

# Remove the legacy project-level Token Creator binding from pre-#530 installs so
# existing setups also converge to self-impersonation. Ignore errors if the binding
# was never granted at the project level.
print_info "Removing legacy project-level 'Service Account Token Creator' binding (if present)..."
gcloud projects remove-iam-policy-binding "${GOOGLE_CLOUD_PROJECT}" \
--role="roles/iam.serviceAccountTokenCreator" \
--member="serviceAccount:${SERVICE_ACCOUNT_EMAIL}"
--member="serviceAccount:${SERVICE_ACCOUNT_EMAIL}" \
--condition=None \
2>/dev/null || true

# Grant logging permissions to the service account
print_info "Granting 'Logging Writer' role to Service Account..."
Expand Down
Loading