Skip to content

fix: make discussion answering model configurable#6113

Open
Haihan-Jiang wants to merge 3 commits into
google:mainfrom
Haihan-Jiang:codex/adk-python-answering-model-config
Open

fix: make discussion answering model configurable#6113
Haihan-Jiang wants to merge 3 commits into
google:mainfrom
Haihan-Jiang:codex/adk-python-answering-model-config

Conversation

@Haihan-Jiang

Copy link
Copy Markdown

Summary

  • Configure the discussion answering agents through LLM_MODEL_NAME instead of hardcoding gemini-3.5-flash.
  • Let the GitHub workflow override both the answering model and Vertex location with repository variables.
  • Document the new knobs and add a regression test that prevents the answering agent model from being hardcoded again.

Fixes #6104

Testing

  • git diff --check
  • python3.12 -m py_compile contributing/samples/adk_team/adk_answering_agent/settings.py contributing/samples/adk_team/adk_answering_agent/agent.py contributing/samples/adk_team/adk_answering_agent/gemini_assistant/agent.py tests/unittests/contributing/test_adk_answering_agent_model_config.py
  • /tmp/adk-python-pr6104-venv/bin/python -m pytest tests/unittests/contributing/test_adk_answering_agent_model_config.py
  • /tmp/adk-python-pr6104-venv/bin/python -m pyink --check contributing/samples/adk_team/adk_answering_agent/settings.py contributing/samples/adk_team/adk_answering_agent/agent.py contributing/samples/adk_team/adk_answering_agent/gemini_assistant/agent.py tests/unittests/contributing/test_adk_answering_agent_model_config.py

@rohityan rohityan self-assigned this Jun 15, 2026
@rohityan rohityan added models [Component] Issues related to model support workflow [Component] This issue is related to ADKworkflow and removed models [Component] Issues related to model support labels Jun 17, 2026
@rohityan

Copy link
Copy Markdown
Collaborator

Hi @Haihan-Jiang , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors before we can proceed with a review.

@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label Jun 17, 2026
@wukath wukath assigned wukath and unassigned rohityan Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request clarification [Status] The maintainer need clarification or more information from the author workflow [Component] This issue is related to ADKworkflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Actions workflow discussion_answering.yml fails on Q&A discussion creation with a Vertex AI 404 for gemini-3.5-flash

3 participants