capture before_run modifications and fix session history sync in runners.py#6147
Open
llalitkumarrr wants to merge 4 commits into
Open
capture before_run modifications and fix session history sync in runners.py#6147llalitkumarrr wants to merge 4 commits into
llalitkumarrr wants to merge 4 commits into
Conversation
…n_callback Fixes a bug in `_run_node_async` where the return value of `before_run_callback` was being swallowed and discarded during workflow execution. Changes introduced: - Captures `corrected_user_message` from the callback response. - Updates `node_input` and `ic.user_content` to pass the modified message into the Workflow graph engine. - Pops the original un-sanitized user event from `ic.session.events` to prevent dirty duplicates in the conversation history before appending the modified event.
rohityan
added
the
services
Collaborator
|
Hi @llalitkumarrr , can you fix the failing unit test. |
Collaborator
Author
|
Hello @rohityan , All unit tests have been fixed and passed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Link to an existing issue (if applicable):
Problem:
ADK 2.0 ignores before_run callback returning a value for workflows. In this case the execution should either stop or use modified message retuned by callback function.
Solution:
Changes introduced:
Captures
corrected_user_messagefrom the callback response.Updates
node_inputandic.user_contentto pass the mutated message into the Workflow graph engine.Pops the original un-sanitized user event from
ic.session.eventsto prevent dirty duplicates in the conversation history before appending the modified event.