fix(oci): preserve all tool results for parallel function calls - #6595
Open
Harshitmishra001 wants to merge 2 commits into
Open
fix(oci): preserve all tool results for parallel function calls#6595Harshitmishra001 wants to merge 2 commits into
Harshitmishra001 wants to merge 2 commits into
Conversation
…tool execution This commit systematically removes the hardcoded assumption across the framework that parts[0] holds the unction_response. When parallel tool results are received, the contents' indices are dynamic. This replaces parts[0] with loop matching to find the correct unction_response.
Harshitmishra001
force-pushed
the
fix-oci-parallel-tool-results
branch
from
August 5, 2026 18:55
7cc8674 to
bf41efd
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
When an agent backed by
OCIGenAILlmhas two or more tools called in parallel in a single turn, only the result of the first tool is forwarded to the OCI model API on the next request. All other tool results are silently dropped because_content_to_oci_messagepreviously only extractedtool_results[0].Solution:
Refactored
_content_to_oci_messageinsrc/google/adk/integrations/oci/_oci_genai_llm.pyto return a list ofToolMessageobjects when multiple tool results are present. Updated_build_chat_detailsto properly flatten this list into themessagesarray payload sent to the OCI API. This maps parallel function responses exactly as expected by the underlying model and mirrors the correct behavior in other integrations (like LiteLLM).Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
This was manually reproduced using the multi-tool parallel calling framework provided in issue #6589. Verified that all parallel function responses generated by
merge_parallel_function_response_eventsare properly surfaced to the model without truncation.Checklist
Additional context
This addresses the exact root cause identified in issue #6589. My Contributor License Agreement (CLA) is signed and verified.