Set fuzzer author as reporter for bugs from external fuzzers by jr2bg · Pull Request #5312 · google/clusterfuzz

jr2bg · 2026-06-04T14:11:48Z

Changes:

Added primary_owner field to Fuzzer model in data_types.py.
Added "Primary owner" input field to the fuzzer edit form in edit-form.html.
Updated fuzzers.py handler to save the primary_owner field.
Updated file_issue in issue_filer.py to use fuzzer.primary_owner as the reporter if available.
Added unit tests in issue_filer_test.py to verify the new behavior.

Feature tests

Show “owner” textbox

Preconditions

Code already on dev instance

Steps

Enter to https://gosst.development.clusterfuzz.com/fuzzers
Click “CREATE NEW”
Screenshot on the popup, highlighting the “Primary owner (email)” textbox

Evidence

Step 3

Show owner entry on Pantheon Audit Logs

Preconditions

Code already on dev instance

Steps

Enter to https://gosst.development.clusterfuzz.com/fuzzers
Click “CREATE NEW”
Fill the form with the next information
- Name: new_fuzzer_with_owner_jabg
- Select/modify jobs: libfuzzer_chrome_asan
- Owner: jabgonzalez@google.com
- Corpus: None
- Fuzzer archive: ???
- Environment variables: None
- External contribution: True
Click “Submit”
Go to dev logs https://pantheon.corp.google.com/logs/query;cursorTimestamp=2026-04-21T13:41:59.977146Z?e=-13802955&mods=logs_tg_prod&project=clusterfuzz-development and search for the new fuzzer
Take a screenshot of the result, highlighting the “Primary owner (email)” entry
Go to https://gosst.development.clusterfuzz.com/fuzzers
Search the recently created fuzzer new_fuzzer_with_owner_jabg
Take a screenshot

Evidence

Step 6

Step 10

dylanjew

Great job overall!

A couple things:

Change the branch to merge this into master
Please run python butler.py format and python butler.py lint
Could you add a section to your description explaining the steps that you went through to test this? It would be great to include screenshots of this is in dev and then verifying the field in the Datastore. Let me know if you have any questions
Similarly, the backfill script component of this bug probably warrants another section in the PR description. It should cover the order of operations for rolling out this change and how you're going to get the primary owner data for the backfill. Again, lmk if I can help with this. The state of our blackbox fuzzers is not great, and there are many that we need to track down their status/owners.

dylanjew · 2026-06-04T14:31:12Z

+if __name__ == '__main__':
+    parser = argparse.ArgumentParser(description='Backfill primary_owner for Fuzzers.')
+    parser.add_argument('--live', action='store_true', help='Perform live updates.')
+    parser.add_argument('--owner', default='default-owner@example.com', help='Default owner email.')


does it make sense to have a default owner? Can we just leave it empty for now if we're not sure, and then keep the existing behavior if it is empty?

dylanjew · 2026-06-04T14:32:19Z

+
+if __name__ == '__main__':
+    parser = argparse.ArgumentParser(description='Backfill primary_owner for Fuzzers.')
+    parser.add_argument('--live', action='store_true', help='Perform live updates.')


I think if you run this using the butler run script the arg should be non-dry-run

dylanjew · 2026-06-04T14:34:37Z

  logs.info(f'Filing new issue for testcase: {testcase.key.id()}.')

  policy = issue_tracker_policy.get(issue_tracker.project)
+  fuzzer = None


does this need to be a DataStore look up?

dylanjew · 2026-06-04T14:44:59Z

+    for fuzzer in query.fetch():
+        print(f"Processing fuzzer: {fuzzer.name}")
+        if not dry_run:
+            fuzzer.primary_owner = default_owner


do we expect the primary_owner to be the same for most of these fuzzers? I would have guessed that there were for example 10 externally contributed fuzzers and maybe 8 different authors of those fuzzers.

dylanjew · 2026-06-04T14:45:56Z

+
+def migrate(dry_run=True, default_owner='default-owner@example.com'):
+    """Migrates fuzzer owners."""
+    query = data_types.Fuzzer.query(


I would add a filter on external_contribution

dylanjew · 2026-06-04T14:47:56Z

+        external_contribution=True,
+        primary_owner='owner@example.com').put()
+
+    issue_tracker = monorail.IssueTracker(IssueTrackerManager('chromium'))


is this the correct way to create an IssueTracker? My understanding is that we migrated from Monorail to IssueTracker/Buganizer at some point.

You are right! Checking it

dylanjew · 2026-06-04T14:49:20Z

+
+    issue_filer.file_issue(self.testcase1, issue_tracker, user_email='reporter@example.com')
+
+    self.assertEqual('owner@example.com', issue_tracker._itm.last_issue.reporter)


nit: is there a better way to check the reporter for the filed issue? _itm.last_issue.reporter seems a bit roundabout and reaches into a private method

- issue_filer.py Get fuzzer from DataStore query, handles cases when no `primary_owner` is found, does not consider yet `external_contribution. - migrate_fuzzer_owners.py Removes the owner

dylanjew · 2026-07-16T15:51:14Z

    issue.components.add(policy.unreproducible_component)

-  issue.reporter = user_email
+  if fuzzer and getattr(fuzzer, 'primary_owner', None):


instead of getattr, can you just check the field directly with fuzzer.primary_owner?

dylanjew · 2026-07-16T15:52:52Z

+  try:
+    fuzzer = data_types.Fuzzer.query(
+        data_types.Fuzzer.name == testcase.fuzzer_name).get()
+  except Exception:


Do you know when an Exception is thrown here? We'd want to log it depending on what happened.

Just to confirm, this isn't an exception because the query returned no results, right?

dylanjew · 2026-07-16T15:53:49Z

@@ -0,0 +1,59 @@
+# Copyright 2026 Google LLC


I think you can just revert this file and keep it in a draft PR for testing or manual backfills. We don't expect to run this more than once

dylanjew · 2026-07-16T15:54:11Z

    fuzzer.sample_testcase = None
    fuzzer.console_output = None
    fuzzer.external_contribution = bool(external_contribution)
+    fuzzer.primary_owner = primary_owner


is there a test you can update alongside this change?

dylanjew · 2026-07-16T15:54:43Z

+        <paper-input
+            label="Primary owner (email)"
+            value="{{fuzzer.primary_owner}}"
+            title="Primary owner for VRP reasons.">


Suggested change

title="Primary owner for VRP reasons.">

title="Primary owner for VRP rewards.">

dylanjew · 2026-07-16T15:59:15Z

+    # Intercept new_issue so we can capture the saved issue object.
+    original_new_issue = issue_tracker.new_issue
+
+    def mock_new_issue():


I'd prefer to mock as little as possible and keep the mocks to the external calls, e.g. the _execute request in test_filed_issue_google_issue_tracker

dylanjew · 2026-07-16T16:05:17Z


-  issue.reporter = user_email
+  if fuzzer and getattr(fuzzer, 'primary_owner', None):
+    issue.reporter = fuzzer.primary_owner


We sometimes use the reporter to determine whether clusterfuzz filed the bug. Is there another place where we are setting metadata of some kind, e.g. a label/hotlist that stays on the bug so that we can continue to track clusterfuzz filed bugs?

jr2bg requested a review from dylanjew June 4, 2026 14:11

jr2bg requested a review from a team as a code owner June 4, 2026 14:11

dylanjew reviewed Jun 4, 2026

View reviewed changes

PauloVLB force-pushed the dev branch from a039693 to 4715844 Compare June 8, 2026 17:39

jr2bg changed the base branch from dev to master June 12, 2026 20:03

jr2bg force-pushed the feature/report-by-fuzzer-owner branch 2 times, most recently from 71a3845 to 1c3affd Compare June 15, 2026 18:52

jr2bg added 4 commits July 16, 2026 13:41

Set fuzzer author as reporter for bugs from external fuzzers

e0113e7

Add license. Modify locations.

eae2447

Migrate from monorail to buganizer.

b39db4e

Resolve comments on issue filing

e4b33cd

- issue_filer.py Get fuzzer from DataStore query, handles cases when no `primary_owner` is found, does not consider yet `external_contribution. - migrate_fuzzer_owners.py Removes the owner

jr2bg force-pushed the feature/report-by-fuzzer-owner branch from 1c3affd to e4b33cd Compare July 16, 2026 13:51

dylanjew reviewed Jul 16, 2026

View reviewed changes


		issue_filer.file_issue(self.testcase1, issue_tracker, user_email='reporter@example.com')

		self.assertEqual('owner@example.com', issue_tracker._itm.last_issue.reporter)

	title="Primary owner for VRP reasons.">
	title="Primary owner for VRP rewards.">

Uh oh!

Conversation

jr2bg commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Feature tests

Show “owner” textbox

Preconditions

Steps

Evidence

Show owner entry on Pantheon Audit Logs

Preconditions

Steps

Evidence

Uh oh!

dylanjew left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jr2bg commented Jun 4, 2026 •

edited

Loading