[VRP] Mark testcases as untrusted if generated by untrusted fuzzers#5330
Draft
PauloVLB wants to merge 1 commit into
Draft
[VRP] Mark testcases as untrusted if generated by untrusted fuzzers#5330PauloVLB wants to merge 1 commit into
PauloVLB wants to merge 1 commit into
Conversation
PauloVLB
changed the title
PauloVLB
force-pushed
the
vrp-untrusted-testcases-from-fuzzers
branch
4 times, most recently
from
980a389 to
e46384a
Compare
PauloVLB
force-pushed
the
vrp-untrusted-fuzzer-safety
branch
from
c09e390 to
f3a6d50
Compare
PauloVLB
force-pushed
the
vrp-untrusted-testcases-from-fuzzers
branch
from
e46384a to
29cebfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Testcases generated by untrusted fuzzers are themselves untrusted and need to be treated with caution. They should not run in insecure environments or be synced to other systems without proper security checks. We need a way to track this safety status at the testcase level.
Proposed Solution
Automatically propagate the "untrusted" status from the fuzzer to the generated testcases. When a new testcase is created, check if the generating fuzzer is marked as
untrusted. If so, set thetrustedfield of theTestcasetoFalse(by default it isTrue).Chaining Note
This PR is chained on top of
vrp-untrusted-fuzzer-uiwhich introduces theuntrustedfield on Fuzzers.Testing
Validated by running fuzzing cycles (simulated) with both trusted and untrusted fuzzers and verifying the
trustedproperty on the resultingTestcaseentities in Datastore.Validation
[Insert Datastore screenshot showing a Testcase with
trusted=Falsegenerated by an untrusted fuzzer]