Gracefully handle metadata look up for update_task check for bots in off GCE#5362
Open
dylanjew wants to merge 3 commits into
Open
Gracefully handle metadata look up for update_task check for bots in off GCE#5362dylanjew wants to merge 3 commits into
dylanjew wants to merge 3 commits into
Conversation
dylanjew
force-pushed
the
dylanj/metadata-check
branch
from
July 15, 2026 17:30
9a49ec6 to
975354e
Compare
dylanjew
force-pushed
the
dylanj/bot-metrics
branch
from
July 15, 2026 17:30
4dd5c13 to
538dcc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are making a bunch of invalid requests to the metadata server when the bot is off GCE. See crbug.com/534369736 for investigation and the corresponding error group
This PR checks that the bot can access the metadata server before making a GET request. If it can't it logs the case rather than an error.
Testing
Metrics in dev