process: Adds logs to the timeout timers that terminate processes#5367
Open
g-ortuno wants to merge 2 commits into
Open
process: Adds logs to the timeout timers that terminate processes#5367g-ortuno wants to merge 2 commits into
g-ortuno wants to merge 2 commits into
Conversation
Collaborator
Author
|
dylanj: PTAL! |
dylanjew
approved these changes
Jul 15, 2026
| result = ProcessResult() | ||
| is_windows = environment.platform() == 'WINDOWS' | ||
|
|
||
| def create_timeout_timer(interval, function, args): |
Collaborator
There was a problem hiding this comment.
nit: is this the standard API for Timers? It might be helpful to add the list of Args to the create_timeout_timer docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://crbug.com/529865766, we are seeing that corpus files are being deleted after the fuzzing round finishes and during corpus merging. We suspect the FuzzTest wrapper is being sent a SIGTERM signal which doesn't properly propagate to the underlying binary, which continue to fuzz.
This PR changes new_process.py to log when we send SIGTERM and SIGKILL after a timeout.