Skip to content

[VRP] Harden testcase safety check in long-lived bots#5368

Draft
PauloVLB wants to merge 1 commit into
vrp-untrusted-testcases-from-fuzzersfrom
vrp-untrusted-testcase-safety
Draft

[VRP] Harden testcase safety check in long-lived bots#5368
PauloVLB wants to merge 1 commit into
vrp-untrusted-testcases-from-fuzzersfrom
vrp-untrusted-testcase-safety

Conversation

@PauloVLB

@PauloVLB PauloVLB commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Problem

Long-lived bots might attempt to handle untrusted testcases locally (e.g., during minimization or analysis) if not properly isolated. The previous safety check relied on the UNTRUSTED_UTASK environment variable, which was unreliably set and often led to false positives or missed detections.

Proposed Solution

Harden the testcase safety check by relying on the rock-solid discriminator environment.is_uworker().
If a long-lived bot (is_uworker() == False) attempts to handle an untrusted testcase (trusted == False), it will trigger a fatal error (log_fatal_and_exit), stopping the processing immediately.

Testing

  • Unit tests in minimize_task_test.py and test helpers in test_utils.py were updated to handle this new validation by default (setting trusted=True for test fixtures).
  • Verified that all core tests pass.

Validation

[Insert logs showing a long-lived bot crashing when attempting to process an untrusted testcase]

@PauloVLB PauloVLB force-pushed the vrp-untrusted-testcase-safety branch 5 times, most recently from 627f503 to 6a39d40 Compare July 16, 2026 20:37
@PauloVLB PauloVLB changed the base branch from master to vrp-untrusted-testcases-from-fuzzers July 16, 2026 20:39
@PauloVLB PauloVLB force-pushed the vrp-untrusted-testcases-from-fuzzers branch from e46384a to 29cebfd Compare July 16, 2026 20:54
@PauloVLB PauloVLB force-pushed the vrp-untrusted-testcase-safety branch from 6a39d40 to 20c1288 Compare July 16, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant