Use android commandline tool v20.#1503
Merged
Merged
Conversation
This is preferable because it will enforce page alignment 16k.
This is needed by the new commandline tool version.
tholenst
reviewed
Jun 2, 2026
tholenst
left a comment
tholenst
left a comment
There was a problem hiding this comment.
Where do we set the target android version? Do you know this?
Collaborator
Author
|
It's here: androidMinSdkVersion = 19 |
|
SGTM. |
tholenst
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the newer commandline tool is preferable, as it will for example by default use 16k alignment.
This change requires us to use java 17, so we also upgrade that.
Also, I got a timeout in the tests. I think we can increase that limit to 30 min.