Migrate some checks off buggy reimplementations of findEnclosingMethod (or TreePath-returning cousins) and onto standard APIs, fixing a bug in the existing standard API.#5919
Merged
Conversation
…od` (or `TreePath`-returning cousins) and onto standard APIs, fixing a bug in the existing standard API. (The bug in the standard API is that it looks for `CLASS` but not other kinds of "class trees.") More generally, consolidate on `ASTHelpers.findEnclosingMethod` (or document why we can't). PiperOrigin-RevId: 939096276
copybara-service
Bot
force-pushed
the
test_933929826
branch
from
18b9203 to
c62014a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate some checks off buggy reimplementations of
findEnclosingMethod(orTreePath-returning cousins) and onto standard APIs, fixing a bug in the existing standard API.(The bug in the standard API is that it looks for
CLASSbut not other kinds of "class trees.")More generally, consolidate on
ASTHelpers.findEnclosingMethod(or document why we can't).