Replace watchdog sleep with interruptable wait for faster teardown#2082
Open
TheRickyZhang wants to merge 1 commit into
Open
Replace watchdog sleep with interruptable wait for faster teardown#2082TheRickyZhang wants to merge 1 commit into
TheRickyZhang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
Runtime::Watchdogteardown prompt by replacing the fixed one-second sleep with an interruptible wait. I don't think there is a current issue open regarding this.The previous loop used
absl::SleepFor(absl::Seconds(1)); the destructor set a stop flag and then joined the thread. If the watchdog was mid-sleep, teardown blocked until that sleep returned, so binaries with many tests must unconditionally wait 1s per test at teardown, even if they finish processing before 1 second has passed.This uses
absl::Notification: the destructor'sNotify()wakes the watchdog immediately, whileWaitForNotificationWithTimeout(absl::Seconds(1))preserves the existing one-second periodic limit-check cadence.Testing
FUZZ_TESTs in unit mode (FUZZTEST_FUZZ_FOR=0): total wall time 30.0s -> 0.01s (per-test teardown 1000ms -> 0ms).