Skip to content

Add a workaround for sigwait returning 0 but not setting the signal number. #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Add a workaround for sigwait returning 0 but not setting the signal number. #2132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions centipede/runner_fork_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,13 @@ void ForkServerCallMeVeryEarly() {
if (sigwait(&wait_sigset, &sig) != 0) {
Exit("###sigwait() failed\n");
}
if (sig == -1) {
// TODO(xinhaoyuan): This should never happen, but I've seen it happen
// on MacOS. Need further investigation.
Log("###sigwait() returns 0 without setting signal number!! Assume "
"SIGCHLD\n");
sig = SIGCHLD;
}
if (sig == SIGINT) {
Log("###Get SIGINT - ignoring\n");
} else if (sig == SIGTERM) {
Expand Down
Loading