Add initial T5Gemma S/S support#947
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jan-wassenberg
left a comment
There was a problem hiding this comment.
Remarkably nice work, very clean code, congrats :) A few suggestions:
Thank you, really appreciate the review and kind words :) |
65263cf to
f218a5f
Compare
|
Hi, I addressed the suggestions in the latest push:
Thanks again for the review! |
jan-wassenberg
left a comment
There was a problem hiding this comment.
Thanks for updating :) A few more questions and one fix:
|
Thanks a lot for the detailed review and suggestions :) I’ve pushed a follow-up commit addressing the comments. A couple of these were cleanup mistakes on my side, especially the temporary single-threading change and the unrelated Bazel flag removal. I’m still new to this codebase, so the review was really helpful for understanding the project conventions better. Thanks again for taking the time to explain the preferred patterns. |
8459a00 to
3f7f53f
Compare
Summary
Adds initial T5Gemma S/S support to gemma.cpp.
This includes:
python/convert_from_safetensors.pyScope
This PR targets T5Gemma v1 S/S only.
Out of scope:
Local Validation
bazel test -c opt //:configs_test //:tensor_info_test //:kv_cache_testt5gemma-s-s-itHelloI am a new user, ...Notes
Opened as draft to get early maintainer feedback on scope, naming, and whether this should be split further.
Additional Note:
//:gemma_lib_testcurrently fails locally for me in an existingGemmaAttentionFlash/EMU128golden mismatch on Apple Silicon; this reproduced outside the T5Gemma changes.Related to #661