refactor!: Pass SarifAnalysis by value#4394
Merged
gmlewis merged 3 commits intoJul 17, 2026
Merged
Conversation
Towards google#3644. BREAKING CHANGE: CodeScanning.UploadSarif now takes SarifAnalysis by value, and SarifAnalysis.CommitSHA, .Ref, and .Sarif are now non-pointer strings.
The upload-an-analysis-as-SARIF-data endpoint accepts an optional validate property that was missing from SarifAnalysis.
gmlewis
added
NeedsReview
alexandear
reviewed
Jul 17, 2026
alexandear
approved these changes
Jul 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4394 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 193 193
Lines 19526 19526
=======================================
Hits 19040 19040
Misses 268 268
Partials 218 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
CodeScanningService.UploadSarifnow takesbodyby value and its required fields are no longer pointers.Towards #3644.
This has two commits:
refactor!—CodeScanning.UploadSarifnow takes itsSarifAnalysisbody by value instead of by pointer, and the three required properties become non-pointer strings (theiromitemptyis dropped). The OpenAPI schema forPOST /repos/{owner}/{repo}/code-scanning/sarifslistscommit_sha,ref, andsarifasrequired, soSarifAnalysis.CommitSHA,.Ref, and.Sarifare nowstring.SarifAnalysisis removed from theparamcheckbody-allowed-pointer-typesallowlist in.golangci.yml.feat— adds the optionalValidate *bool(validate) property, which the same endpoint accepts butSarifAnalysiswas missing.SarifAnalysisis the dedicated body of that single endpoint (the response is a separateSarifID), so there is no shared-type / split concern. The generated accessors are regenerated.