Skip to content

docs: Deprecate PullRequest.MergeCommitSHA - #4685

Open
nakultt wants to merge 2 commits into
google:masterfrom
nakultt:docs/deprecate-pr-merge-commit-sha
Open

nakultt wants to merge 2 commits into
google:masterfrom
nakultt:docs/deprecate-pr-merge-commit-sha

Conversation

@nakultt

@nakultt nakultt commented Oct 28, 2026

Copy link
Copy Markdown

Updates #4077.

GitHub REST API version 2026-03-10 removed merge_commit_sha from pull request responses. The field is kept for older API versions, GHES and webhook payloads, and is marked Deprecated: instead.

GitHub REST API version 2026-03-10 removed merge_commit_sha from pull
request responses. The field is kept for older API versions, GHES and
webhook payloads.

Updates google#4077.
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 28, 2026

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nakultt!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @Not-Dhananjay-Mishra

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (143d047) to head (4ab1a9c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4685   +/-   ##
=======================================
  Coverage   98.63%   98.64%           
=======================================
  Files         201      202    +1     
  Lines       18951    19004   +53     
=======================================
+ Hits        18693    18746   +53     
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread github/pulls.go Outdated
Rebaseable *bool `json:"rebaseable,omitempty"`
MergedBy *User `json:"merged_by,omitempty"`
MergeCommitSHA *string `json:"merge_commit_sha,omitempty"`
MergeCommitSHA *string `json:"merge_commit_sha,omitempty"` // Deprecated: Removed from REST API responses in API version 2026-03-10.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants