Skip to content

test: Cover stateless GitHub App installation tokens - #4687

Open
JamBalaya56562 wants to merge 1 commit into
google:masterfrom
JamBalaya56562:test/4577-stateless-installation-tokens
Open

JamBalaya56562 wants to merge 1 commit into
google:masterfrom
JamBalaya56562:test/4577-stateless-installation-tokens

Conversation

@JamBalaya56562

Copy link
Copy Markdown
Contributor

Closes: #4577
Closes: #4598

This takes over #4577 by @sundaypaulfz3-cell and #4598 by @rajveer002, which add the same kind of tests and have had no activity since 2026-09-18 and 2026-10-03 (#4577 is blocked on the Google CLA, and #4598 on the lint fix that @gmlewis asked for). Thank you both for the original work! If either of you would like to finish your PR instead, I'm happy to close this one.

GitHub App installation tokens now use the stateless ghs_APPID_JWT format, which is about 520 characters long instead of 40 (changelog). go-github already treats tokens as opaque strings, so this PR only adds tests that guard against length or format assumptions:

Changes from #4577 and #4598:

  • The test token follows the documented format: the ghs_ prefix, an app ID, and a JWT with two dots, 520 characters in total.
  • Uses %v instead of %d for the fmtpercentv linter.

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (c678307) to head (3503f78).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4687   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         202      202           
  Lines       19004    19004           
=======================================
  Hits        18746    18746           
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 29, 2026

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @JamBalaya56562!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @Not-Dhananjay-Mishra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants