Repository navigation
Conversation
An untagged anonymous field holding a nil pointer to a struct was encoded as an empty parameter named after the embedded type, e.g. ListOptions=&state=open instead of state=open. A nil embedded struct pointer has no fields to promote, so encode nothing for it, as encoding/json does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An anonymous field that is a nil pointer to a struct was encoded as an empty parameter named after the embedded type:
A nil embedded struct pointer has no fields to promote, so it now encodes nothing, the same as
encoding/jsondoes. With a non-nil&ListOptions{}the output was alreadystate=open.Only untagged nil pointers to structs are affected. Kept as before:
urltag (url:"inner"), which is still encoded asinner=when nil, like any other nil pointer field*MyString), which still use the type name as the keyTwo side effects:
*time.Timeused to produceTime=and now produces nothing. A non-nil embeddedtime.Timealready produced nothing.Encoderno longer hasEncodeValuescalled with the type name as key. Non-nil embedded structs are promoted and never went throughEncoder, so now neither case calls it.Tests: the new cases in
TestValues_EmbeddedStructsfail on master (they get an extraInner/N[Inner]key) and pass with this change. The named-pointer case passes in both.go test -race ./...passes with 100% coverage;go vetandgofmtare clean.This change was drafted with Claude Code (claude-opus-5-5); the test results above are from the runs described.