Skip to content

query: honor Encoder through indirect pointers - #201

Open
terminalchai wants to merge 1 commit into
google:masterfrom
terminalchai:fix/indirect-pointer-encoder
Open

terminalchai wants to merge 1 commit into
google:masterfrom
terminalchai:fix/indirect-pointer-encoder

Conversation

@terminalchai

Copy link
Copy Markdown

A non-nil double pointer to a custom encoder uses default formatting because the encoder check runs before pointer dereferencing. Stop dereferencing at the first pointer that implements Encoder so indirect and direct pointers use the same encoding. The regression produced v=1 instead of v=_1 on master. All tests and go vet passed on Go 1.26.1 for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant