Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Sami Chergui <83331159+Yshuro@users.noreply.github.com>
Yshuro
force-pushed
the
fix/iszero-named-types
branch
from
November 19, 2026 16:12
f83f17b to
e635de9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for Values states:
However, isEmptyValue evaluated the switch v.Kind() before checking the zeroable interface. As a result, named scalar types (such as ype Limit int) or named collection types (such as ype Tags []string) returning custom emptiness from IsZero() were handled by the kind switch instead, causing sentinel values like Limit(-1) or CustomString(unset) to be included in query parameters despite omitempty.
This change checks the zeroable interface (IsZero() bool) before the kind-specific switch, while preserving the immediate empty evaluation for nil pointer and interface values.
Fixes #202.