Minor fixes: survey media access, Android intent fallback, LOI property refactor - #2569
Closed
rfontanarosa wants to merge 6 commits into
Closed
Minor fixes: survey media access, Android intent fallback, LOI property refactor#2569rfontanarosa wants to merge 6 commits into
rfontanarosa wants to merge 6 commits into
Conversation
rfontanarosa
commented
Jul 22, 2026
Collaborator
- Drop per-user scoping of survey media in Storage rules — any user with data-collection permission on a survey can read/write its media, not only the uploading user.
- Add an explicit Play Store fallback URL (S.browser_fallback_url) to the Android intent so the store opens when the app isn't installed (+ tests).
- Extract regenerateLoiProperties (and export propertiesPbToObject) from onCreateLoiHandler for reuse/testability.
- Add a fetchSubmission helper to Datastore.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
- Coverage 62.70% 62.13% -0.58%
==========================================
Files 119 121 +2
Lines 2896 2947 +51
Branches 434 441 +7
==========================================
+ Hits 1816 1831 +15
- Misses 1018 1053 +35
- Partials 62 63 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
There are a few related things in this one PR. Can you please have an agent split them into multiple PRS? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.