Skip to content

Minor fixes: survey media access, Android intent fallback, LOI property refactor - #2569

Closed
rfontanarosa wants to merge 6 commits into
masterfrom
rfontanarosa/minor-fixes-2
Closed

Minor fixes: survey media access, Android intent fallback, LOI property refactor#2569
rfontanarosa wants to merge 6 commits into
masterfrom
rfontanarosa/minor-fixes-2

Conversation

@rfontanarosa

Copy link
Copy Markdown
Collaborator
  • Drop per-user scoping of survey media in Storage rules — any user with data-collection permission on a survey can read/write its media, not only the uploading user.
  • Add an explicit Play Store fallback URL (S.browser_fallback_url) to the Android intent so the store opens when the app isn't installed (+ tests).
  • Extract regenerateLoiProperties (and export propertiesPbToObject) from onCreateLoiHandler for reuse/testability.
  • Add a fetchSubmission helper to Datastore.

@rfontanarosa rfontanarosa self-assigned this Jul 22, 2026
@rfontanarosa
rfontanarosa requested a review from gino-m July 22, 2026 14:51
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.13%. Comparing base (019f855) to head (d65c599).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ding-page/android-intent-landing-page.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2569      +/-   ##
==========================================
- Coverage   62.70%   62.13%   -0.58%     
==========================================
  Files         119      121       +2     
  Lines        2896     2947      +51     
  Branches      434      441       +7     
==========================================
+ Hits         1816     1831      +15     
- Misses       1018     1053      +35     
- Partials       62       63       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gino-m

gino-m commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

There are a few related things in this one PR. Can you please have an agent split them into multiple PRS?

@rfontanarosa

Copy link
Copy Markdown
Collaborator Author

closed because it has been split there:
#2575
#2576
#2577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants