Prune or simplify methods for converting int to enum#684
Open
copybara-service[bot] wants to merge 1 commit into
Open
Prune or simplify methods for converting int to enum#684copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_922897756
branch
3 times, most recently
from
6cf6066 to
e9c922a
Compare
For int-to-actual-enum conversions, just use static_cast directly. For enum-like objects (currently Version), CHECK-fail if the value is invalid (similar to what ColorSpaceToInt did previously). This is more brittle, but allows the code to be simplified, and tests strictly assert that the Version values which can be passed from Kotlin match those in native code. PiperOrigin-RevId: 922897756
copybara-service
Bot
force-pushed
the
test_922897756
branch
from
e9c922a to
d477ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prune or simplify methods for converting int to enum
For int-to-actual-enum conversions, just use static_cast directly. For enum-like objects (currently Version), CHECK-fail if the value is invalid (similar to what ColorSpaceToInt did previously). This is more brittle, but allows the code to be simplified, and tests strictly assert that the Version values which can be passed from Kotlin match those in native code.