Skip to content

Add ToStringPretty() multi-line serializer to the serde_json bridge. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ToStringPretty() multi-line serializer to the serde_json bridge. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions serde_json/rust/json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,12 @@ impl SerdeJson {
self.serialize_with_formatter(sort_keys, SpacedFormatter)
}

/// Converts a [SerdeJson] to a pretty-printed, multi-line string with
/// two-space indentation.
pub fn to_string_pretty(&self, sort_keys: bool) -> RawString {
self.serialize_with_formatter(sort_keys, serde_json::ser::PrettyFormatter::new())
}

pub fn get_keys(&self) -> Result<VecRawString, RawString> {
let object = match self.value.as_object() {
Some(o) => o,
Expand Down
4 changes: 4 additions & 0 deletions serde_json/serde_json_bridge.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,10 @@ std::string SerdeJson::ToStringSpaced(bool sort_keys) const {
return FromRustRawString(json_obj_.to_string_spaced(sort_keys));
}

std::string SerdeJson::ToStringPretty(bool sort_keys) const {
return FromRustRawString(json_obj_.to_string_pretty(sort_keys));
}

absl::StatusOr<std::vector<std::string>> SerdeJson::GetKeys() const {
rs_std::Result<rust::json::VecRawString,
rust::raw_string::RawString>
Expand Down
3 changes: 3 additions & 0 deletions serde_json/serde_json_bridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ class SerdeJson final {
// Convert this object to string with spaces after colons and commas.
// Example: {"key": "value", "num": 42}
std::string ToStringSpaced(bool sort_keys = true) const;
// Convert this object to a pretty-printed, multi-line string with two-space
// indentation.
std::string ToStringPretty(bool sort_keys = true) const;
absl::StatusOr<::google::protobuf::Struct> ToProtoStruct() const;
absl::StatusOr<::google::protobuf::Value> ToProtoValue() const;

Expand Down
Loading