Skip to content

Substrate#201

Merged
aojea merged 14 commits into
google:mainfrom
aojea:substrate
Jul 13, 2026
Merged

Substrate#201
aojea merged 14 commits into
google:mainfrom
aojea:substrate

Conversation

@aojea

@aojea aojea commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces binary-level capability roles (sam:role:node, sam:role:sambox, and sam:role:router) to enforce the principle of least privilege during client enrollment and startup. The EnrollRequest and BootstrapEnrollRequest protobuf messages have been updated to include a requested_role field, and the control plane now validates that the client is authorized for the requested role before minting the Biscuit token. Additionally, nano-init has been refactored to support explicit copy and run subcommands. Feedback on these changes includes addressing a potential silent write failure in copyFile by checking the destination file's Close() error, and resolving a duplicate role bug in MintBiscuitToken when the requested role is a custom access role.

Comment thread cmd/nano-init/main.go
Comment thread internal/identity/biscuit.go
@aojea
aojea merged commit b47515d into google:main Jul 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant