Skip to content

ci: publish and deploy sam-console to GKE testnet#213

Merged
aojea merged 1 commit into
google:mainfrom
aojea:substrate
Jul 16, 2026
Merged

ci: publish and deploy sam-console to GKE testnet#213
aojea merged 1 commit into
google:mainfrom
aojea:substrate

Conversation

@aojea

@aojea aojea commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@aojea
aojea merged commit b81e5fc into google:main Jul 16, 2026
11 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sam-console image source to a specific container registry and modifies the SAM_ADMIN_TOKEN secret reference to be environment-specific. The reviewer recommends using a variable for the image registry prefix instead of hardcoding it to maintain flexibility across different deployment environments.

containers:
- name: sam-console
image: ${IMAGE_PREFIX}sam-console:${TAG}
image: ghcr.io/google/sam-console:${IMAGE_TAG}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the image registry ghcr.io/google/ reduces this template's flexibility. It's better to use a variable for the image prefix to allow this template to be used with different container registries across various environments (e.g., local development, testing, production).

You could reintroduce the ${IMAGE_PREFIX} variable and set it to ghcr.io/google/ in your GKE testnet CI/CD pipeline. For other environments like local development, it could be left empty to use local images.

        image: ${IMAGE_PREFIX}sam-console:${IMAGE_TAG}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant