Skip to content

.github/workflows: use repo-specific recommendations for code review#7021

Open
tarasmadan wants to merge 1 commit intogoogle:masterfrom
tarasmadan:use-repo-review-rules
Open

.github/workflows: use repo-specific recommendations for code review#7021
tarasmadan wants to merge 1 commit intogoogle:masterfrom
tarasmadan:use-repo-review-rules

Conversation

@tarasmadan
Copy link
Copy Markdown
Collaborator

@tarasmadan tarasmadan commented Mar 27, 2026

Updates #6891

@tarasmadan tarasmadan marked this pull request as ready for review March 27, 2026 16:29
@tarasmadan tarasmadan force-pushed the use-repo-review-rules branch from b2ecb85 to c980500 Compare March 27, 2026 16:33
@tarasmadan tarasmadan enabled auto-merge March 27, 2026 16:33
Comment thread skills/DVYUKOV.md Outdated
@tarasmadan tarasmadan force-pushed the use-repo-review-rules branch from c980500 to e74c8bf Compare March 27, 2026 16:50
Copy link
Copy Markdown
Collaborator

@dvyukov dvyukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you reviewed the guidelines manually?

Comment thread skills/DVYUKOV.md
- Use tabs for HTML templates.

> [!TIP]
> This file is automatically updated by the workflow in `.github/workflows/update-review-guidelines.yml` to reflect new feedback as it occurs!
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-cli remove this TIP

@tarasmadan tarasmadan force-pushed the use-repo-review-rules branch from e74c8bf to dedc6a5 Compare April 7, 2026 10:39
@tarasmadan
Copy link
Copy Markdown
Collaborator Author

@gemini-cli remove the TIP section at the end

@syzbot-noreply
Copy link
Copy Markdown

🤖 Hi @tarasmadan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@syzbot-noreply
Copy link
Copy Markdown

syzbot-noreply commented Apr 7, 2026

🤖 AI Assistant: Plan of Action

I have analyzed the request and propose the following plan. This plan will not be executed until it is approved by a maintainer.

Resource Estimate:

  • Estimated Tool Calls: ~2
  • Files to Modify: 1

Proposed Steps:

  • Step 1: Remove the > [!TIP] section at the end of skills/DVYUKOV.md.

Please review this plan. To approve, comment @gemini-cli /approve on this issue. To make changes, comment changes needed.

@tarasmadan
Copy link
Copy Markdown
Collaborator Author

Have you reviewed the guidelines manually?

Yes. The first version was too long and we compressed it with @ramosian-glider.
Last lines are coming from #7019 and the border between these two PRs was quite blurred for me. Thanks for highlighting.

@tarasmadan
Copy link
Copy Markdown
Collaborator Author

@gemini-cli /approve

@syzbot-noreply
Copy link
Copy Markdown

🤖 Hi @tarasmadan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@syzbot-noreply
Copy link
Copy Markdown

🤖 I'm sorry @tarasmadan, but I was unable to process your request. Please see the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants