Avoid redundant loads, calculations, and branches in ListPushBatch.#361
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Avoid redundant loads, calculations, and branches in ListPushBatch.#361copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
* We avoid reloading `freelist_` and `embed_count_` on every object. * We hoist the calculation of `host` to only the empty `freelist_` and full `embed_count_ cases. * We peel off the `freelist_ == kListEnd`, since this case only needs to be handled once on the first element of the batch. PiperOrigin-RevId: 949140087
copybara-service
Bot
force-pushed
the
test_949140087
branch
from
July 16, 2026 21:27
7f93ba7 to
7a60ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid redundant loads, calculations, and branches in ListPushBatch.
freelist_andembed_count_on every object.hostto only the emptyfreelist_and full`embed_count_ cases.
freelist_ == kListEnd, since this case only needs to behandled once on the first element of the batch.