Correct error trait rustdoc cfgs - #3670
Open
joshlf wants to merge 1 commit into
Open
Conversation
The Error implementations are available either on Rust 1.81 or newer or when the std feature is enabled, but their rustdoc cfgs currently require both. Match the documented availability to the actual compilation cfgs. *Authored by an AI agent acting on Josh Liebow-Feeser's behalf.* Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3670 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 20 20
Lines 6147 6147
=======================================
Hits 5644 5644
Misses 503 503 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each error type implements
Erroreither on Rust 1.81 or newer or when thestdfeature is enabled. The rustdocdoc(cfg(...))annotations currently say that both conditions must hold.Change the four annotations from
all(...)toany(...)so the generated documentation matches the actual compilation cfgs.Authored by an AI agent acting on Josh Liebow-Feeser's behalf.