test(auth): verify malformed JSON array payloads do not crash credentials parser#16156
Merged
Conversation
…ials parser The C++ test sufficiency gap report originally assumed that calling `.find()` on an array payload would crash the parser. However, the `nlohmann::json` library safely returns `.end()` on non-object types. Added this test to explicitly verify and enforce this type-safe behavior moving forward without needing redundant production code checks.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16156 +/- ##
==========================================
- Coverage 92.20% 92.20% -0.01%
==========================================
Files 2264 2264
Lines 209084 209084
==========================================
- Hits 192791 192786 -5
- Misses 16293 16298 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nlohmann::jsonlibrary safely returns.end()on non-object types. Added this test to explicitly verify and enforce this type-safe behavior moving forward.