chore(deps): update grpc#16158
Conversation
|
/gcbrun |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the gRPC dependency version across several files, including Bazel configurations, Dockerfiles, and documentation. However, there is a version mismatch where MODULE.bazel is updated to the stable 1.81.1 release, while other files are updated to the pre-release 1.82.0-pre1 version. Feedback recommends aligning all gRPC references to the stable 1.81.1 release to ensure consistency. Additionally, it is suggested to use an ARG in the Dockerfiles to define the gRPC version instead of hardcoding it to improve maintainability.
| "https://github.com/grpc/grpc/archive/v1.82.0-pre1.tar.gz", | ||
| ], | ||
| repo_mapping = { | ||
| "@com_google_absl": "@abseil-cpp", | ||
| "@com_github_grpc_grpc": "@grpc", | ||
| }, | ||
| sha256 = "7bf97c11cf3808d650a3a025bbf9c5f922c844a590826285067765dfd055d228", | ||
| strip_prefix = "grpc-1.74.1", | ||
| sha256 = "7c91601663de3363887c57df1a4806f6f0cd2c7c4e6b208aca398496d014f7ee", | ||
| strip_prefix = "grpc-1.82.0-pre1", |
There was a problem hiding this comment.
There is a version mismatch in this pull request: MODULE.bazel is being updated to the stable 1.81.1 release, whereas bazel/workspace0.bzl, the Dockerfiles, and the documentation are being updated to the pre-release 1.82.0-pre1 version.
To ensure consistency and avoid using pre-release versions in production/main branch builds, please align all gRPC references to the stable 1.81.1 release (and update the corresponding SHA256 hash here).
| # ```bash | ||
| WORKDIR /var/tmp/build/grpc | ||
| RUN curl -fsSL https://github.com/grpc/grpc/archive/v1.71.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/grpc/grpc/archive/v1.82.0-pre1.tar.gz | \ |
There was a problem hiding this comment.
To improve maintainability and adhere to the repository's general rules, use an ARG to define the gRPC version instead of hardcoding it in the curl command. This makes it easier to update the version across multiple Dockerfiles in the future.
Additionally, please ensure the version is aligned with the stable 1.81.1 release used in MODULE.bazel rather than the pre-release 1.82.0-pre1.
ARG GRPC_VERSION=1.81.1
RUN curl -fsSL https://github.com/grpc/grpc/archive/v${GRPC_VERSION}.tar.gz | \
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16158 +/- ##
=======================================
Coverage 92.20% 92.21%
=======================================
Files 2264 2264
Lines 209092 209092
=======================================
+ Hits 192802 192810 +8
+ Misses 16290 16282 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
This PR contains the following updates:
1.81.0→1.81.1v1.74.1→v1.82.0-pre1v1.71.2→v1.82.0-pre1v1.81.0→v1.82.0-pre1Release Notes
grpc/grpc (grpc)
v1.81.1Compare Source
This is release 1.81.0 (graphic) of gRPC Core.
For gRPC documentation, see grpc.io. For previous releases, see Releases.
This release contains refinements, improvements, and bug fixes, with highlights listed below.
Core
Objective-C
Python
Ruby
Configuration
📅 Schedule: (UTC)
* * * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.