Skip to content

chore(bigquery-jdbc): fix Dockerfile to install proper dependencies - #13990

Merged
logachev merged 2 commits into
mainfrom
kirl/fix_dockerfile
Aug 4, 2026
Merged

chore(bigquery-jdbc): fix Dockerfile to install proper dependencies#13990
logachev merged 2 commits into
mainfrom
kirl/fix_dockerfile

Conversation

@logachev

@logachev logachev commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

It used to work when JDBC was residing within BQ, but after it was moved & we got extra SDK dependencies, Dockerfile build got broken.

@logachev
logachev marked this pull request as ready for review August 4, 2026 20:00
@logachev
logachev requested review from a team as code owners August 4, 2026 20:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dockerfile for java-bigquery-jdbc to install the java-bigquery-jdbc module instead of java-bigquery. However, this change will cause the build to fail because the java-bigquery-jdbc module has been moved out of the google-cloud-java repository. The reviewer suggests explicitly listing the required SDK dependencies from google-cloud-java (such as java-bigquery and java-bigquerystorage) instead of attempting to install the JDBC module from the parent repository.

Comment thread java-bigquery-jdbc/Dockerfile
@logachev
logachev enabled auto-merge (squash) August 4, 2026 20:15
@logachev
logachev merged commit f84034b into main Aug 4, 2026
203 of 204 checks passed
@logachev
logachev deleted the kirl/fix_dockerfile branch August 4, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants