Repository navigation
feat: Session support for mutateRows #14644
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,82 @@ | ||||||||||||
| /* | ||||||||||||
| * Copyright 2026 Google LLC | ||||||||||||
| * | ||||||||||||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||
| * you may not use this file except in compliance with the License. | ||||||||||||
| * You may obtain a copy of the License at | ||||||||||||
| * | ||||||||||||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||
| * | ||||||||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||||||||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||
| * See the License for the specific language governing permissions and | ||||||||||||
| * limitations under the License. | ||||||||||||
| */ | ||||||||||||
| package com.google.cloud.bigtable.data.v2.internal.compat.ops; | ||||||||||||
|
|
||||||||||||
| import com.google.bigtable.v2.OpenAuthorizedViewRequest; | ||||||||||||
| import com.google.bigtable.v2.OpenTableRequest.Permission; | ||||||||||||
| import com.google.bigtable.v2.SessionMutateRowsRequest; | ||||||||||||
| import com.google.cloud.bigtable.data.v2.internal.api.AuthorizedViewAsync; | ||||||||||||
| import com.google.cloud.bigtable.data.v2.internal.api.Client; | ||||||||||||
| import com.google.cloud.bigtable.data.v2.internal.api.TableAsync; | ||||||||||||
| import com.google.cloud.bigtable.data.v2.models.AuthorizedViewId; | ||||||||||||
| import com.google.cloud.bigtable.data.v2.models.BulkMutation; | ||||||||||||
| import com.google.cloud.bigtable.data.v2.models.TableId; | ||||||||||||
| import com.google.cloud.bigtable.data.v2.models.TargetId; | ||||||||||||
| import io.grpc.Deadline; | ||||||||||||
|
Comment on lines
+27
to
+28
Contributor
There was a problem hiding this comment. Import
Suggested change
|
||||||||||||
| import java.io.IOException; | ||||||||||||
| import java.util.concurrent.CompletableFuture; | ||||||||||||
|
|
||||||||||||
| public class MutateRowsShim implements UnaryShim<BulkMutation, Void> { | ||||||||||||
|
|
||||||||||||
| private final SessionPoolMap<TableId, TableAsync> tables; | ||||||||||||
| private final SessionPoolMap<AuthorizedViewId, AuthorizedViewAsync> authViews; | ||||||||||||
|
|
||||||||||||
| public MutateRowsShim(Client client) { | ||||||||||||
| tables = | ||||||||||||
|
Comment on lines
+37
to
+38
Contributor
There was a problem hiding this comment. Add a defensive null check for the public MutateRowsShim(Client client) {
Preconditions.checkNotNull(client, "client is required");
tables =References
Contributor
There was a problem hiding this comment. we should consider share the pool with MutateRow. See my PR (although is not approved yet 😂 ) |
||||||||||||
| new SessionPoolMap<>( | ||||||||||||
| k -> client.openTableAsync(k.getTableId(), Permission.PERMISSION_WRITE)); | ||||||||||||
| authViews = | ||||||||||||
| new SessionPoolMap<>( | ||||||||||||
| k -> | ||||||||||||
| client.openAuthorizedViewAsync( | ||||||||||||
| k.getTableId(), | ||||||||||||
| k.getAuthorizedViewId(), | ||||||||||||
| OpenAuthorizedViewRequest.Permission.PERMISSION_WRITE)); | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| @Override | ||||||||||||
| public void close() throws IOException { | ||||||||||||
| tables.invalidateAll(); | ||||||||||||
| authViews.invalidateAll(); | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| @Override | ||||||||||||
| public boolean supports(BulkMutation request) { | ||||||||||||
| // TODO: enable when server side changes is rolled out | ||||||||||||
| return false; | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| @Override | ||||||||||||
| public CompletableFuture<Void> call(BulkMutation request, Deadline deadline) { | ||||||||||||
| TargetId targetId = request.getTargetId(); | ||||||||||||
|
|
||||||||||||
| SessionMutateRowsRequest innerReq = request.toSessionProto(); | ||||||||||||
|
|
||||||||||||
| if (targetId instanceof TableId) { | ||||||||||||
| return tables.apply( | ||||||||||||
| (TableId) targetId, t -> t.mutateRows(innerReq, deadline).thenApply(r -> null)); | ||||||||||||
| } | ||||||||||||
| if (targetId instanceof AuthorizedViewId) { | ||||||||||||
| return authViews.apply( | ||||||||||||
| (AuthorizedViewId) targetId, v -> v.mutateRows(innerReq, deadline).thenApply(r -> null)); | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| CompletableFuture<Void> f = new CompletableFuture<>(); | ||||||||||||
| f.completeExceptionally( | ||||||||||||
| new UnsupportedOperationException("Unsupported targetId type: " + targetId)); | ||||||||||||
| return f; | ||||||||||||
| } | ||||||||||||
| } | ||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment can be removed. My PR is removing it in all other places.