Skip to content

chore(librarian): remove api_reference and extra_versioned_modules - #14671

Open
sofisl wants to merge 1 commit into
mainfrom
remove-api-reference
Open

sofisl wants to merge 1 commit into
mainfrom
remove-api-reference

Conversation

@sofisl

@sofisl sofisl commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Remove obsolete api_reference and extra_versioned_modules fields from librarian.yaml and the corresponding .repo-metadata.json files.

For googleapis/librarian#6682
For googleapis/librarian#6690

Remove obsolete api_reference and extra_versioned_modules fields from librarian.yaml and .repo-metadata.json.

For googleapis/librarian#6682

For googleapis/librarian#6690

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up metadata configuration by removing deprecated or redundant fields, such as api_reference and extra_versioned_modules, from several .repo-metadata.json files and the librarian.yaml configuration for various Google Cloud Java libraries (including asset, bigtable, datastore, pubsub, and storage). I have no additional feedback to provide as the changes are straightforward and correct.

@sofisl
sofisl marked this pull request as ready for review October 16, 2026 18:21
@sofisl
sofisl requested review from a team as code owners October 16, 2026 18:21
"library_type": "GAPIC_COMBO",
"codeowner_team": "@googleapis/bigtable-team",
"issue_tracker": "https://issuetracker.google.com/savedsearches/559777",
"extra_versioned_modules": "google-cloud-bigtable-emulator,google-cloud-bigtable-emulator-core",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it cause any generation diff?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these .repo-metadata.json diffs are the generated diff. The changes are in librarian.yaml

@sofisl

sofisl commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Not besides these changes, please see googleapis/librarian#6690

@zhumin8

zhumin8 commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

nit: can you add in description that you ran librarian generate upon librarian.yaml changes?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants