Repository navigation
feat(storage): wire operation metrics in gRPC veneer - #14729
Open
nidhiii-27 wants to merge 5 commits into
Open
nidhiii-27 wants to merge 5 commits into
nidhiii-27 wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates StorageMetricsContext and StorageClientMetrics across various Google Cloud Storage operations in the Java SDK to enable comprehensive metric tracking for single and multi-step operations. The review feedback highlights several critical edge cases where metrics could be double-recorded or where operation failures (such as during chunk copying, initial rewrite calls, or starting resumable writes) would go unrecorded. The reviewer suggests introducing state tracking in GapicCopyWriter and wrapping initial asynchronous or multi-step operations in try-catch blocks to ensure metrics are accurately recorded exactly once for both successes and failures.
nidhiii-27
force-pushed
the
feat/storage-veneer-operation-metrics
branch
from
October 22, 2026 05:55
3011be4 to
261bc60
Compare
nidhiii-27
force-pushed
the
feat/storage-grpc-veneer-operation-metrics
branch
from
October 22, 2026 05:55
6b44605 to
354f72b
Compare
…e-grpc-veneer-operation-metrics
…s [Generated-by: AI]
…e-grpc-veneer-operation-metrics
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires operation metrics into the gRPC veneer implementation.
GrpcStorageImplacross unary calls, multi-step ACL operations, and streaming operations.GapicCopyWriter,GrpcBlobReadChannel, andGrpcBlobWriteChannel.Stacked on #14698.