feat(spanner): split handwritten spanner library from its gapics and protos#8927
Draft
feywind wants to merge 9 commits into
Draft
feat(spanner): split handwritten spanner library from its gapics and protos#8927feywind wants to merge 9 commits into
feywind wants to merge 9 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes local proto files and the synth.py script, transitioning the codebase to use the external @google-cloud/spanner-api package. Imports and paths are updated across benchmarks, tests, mock servers, and source files. The review feedback highlights a compilation error in system-test/spanner.ts due to a missing import of protos, and recommends replacing fragile, hardcoded relative paths to node_modules with dynamic path resolution using require.resolve across multiple test and mock files.
feywind
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in the effort to remove OwlBot from the standard repo path. A new package (spanner-api) takes care of what OwlBot used to do (shuffle in new protos and generated gapic classes).
Internal: b/531788771