Skip to content

feat(spanner): split GAPIC from the spanner handwritten package #8931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quirogas wants to merge 3 commits into from
Closed

feat(spanner): split GAPIC from the spanner handwritten package #8931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc1ff9d
feat(spanner): use @google-cloud/spanner-api dependency
quirogas Jul 21, 2026
f09f7ee
feat(spanner): re-export DatabaseAdminClient, InstanceAdminClient, Sp…
quirogas Jul 21, 2026
ed48433
Merge branch 'main' into feat/disentangle-spanner-handwritten
quirogas Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions handwritten/spanner/.OwlBot.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion handwritten/spanner/benchmark/spanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import * as mock from '../test/mockserver/mockspanner';
import {SimulatedExecutionTime} from '../test/mockserver/mockspanner';
import * as mockInstanceAdmin from '../test/mockserver/mockinstanceadmin';
import * as mockDatabaseAdmin from '../test/mockserver/mockdatabaseadmin';
import {google} from '../protos/protos';
import {google} from '@google-cloud/spanner-api/build/protos/protos';
import {SessionPoolOptions} from '../src/session-pool';
import protobuf = google.spanner.v1;
import {performance} from 'perf_hooks';
Expand Down
2 changes: 1 addition & 1 deletion handwritten/spanner/google-cloud-spanner-executor/src/cloud-client-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import {ServerDuplexStream, status} from '@grpc/grpc-js';
import {Spanner} from '../../src';
import {trace, context, Tracer} from '@opentelemetry/api';
import * as protos from '../../protos/protos';
import * as protos from '@google-cloud/spanner-api/build/protos/protos';
import {CloudUtil} from './cloud-util';
import {OutcomeSender, ExecutionFlowContextInterface} from './cloud-executor';
import spanner = protos.google.spanner;
Expand Down
2 changes: 1 addition & 1 deletion handwritten/spanner/google-cloud-spanner-executor/src/cloud-executor-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import {ServerDuplexStream, status} from '@grpc/grpc-js';
import {trace, context, Tracer} from '@opentelemetry/api';
import {CloudClientExecutor} from './cloud-client-executor';
import * as protos from '../../protos/protos';
import * as protos from '@google-cloud/spanner-api/build/protos/protos';
import spanner = protos.google.spanner;
import SpannerAsyncActionRequest = spanner.executor.v1.SpannerAsyncActionRequest;
import SpannerAsyncActionResponse = spanner.executor.v1.SpannerAsyncActionResponse;
Expand Down
2 changes: 1 addition & 1 deletion handwritten/spanner/google-cloud-spanner-executor/src/cloud-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

import {status} from '@grpc/grpc-js';
import * as protos from '../../protos/protos';
import * as protos from '@google-cloud/spanner-api/build/protos/protos';

// Import Protobuf types
import spanner = protos.google.spanner;
Expand Down
2 changes: 1 addition & 1 deletion handwritten/spanner/observability-test/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import * as through from 'through2';
import {EventEmitter} from 'events';
import * as assert from 'assert';
import * as extend from 'extend';
import {google} from '../protos/protos';
import {google} from '@google-cloud/spanner-api/build/protos/protos';
import {
BatchWriteOptions,
CommitCallback,
Expand Down
2 changes: 1 addition & 1 deletion handwritten/spanner/observability-test/spanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import * as assert from 'assert';
import {grpc} from 'google-gax';
import {google} from '../protos/protos';
import {google} from '@google-cloud/spanner-api/build/protos/protos';
import {Database, Instance, Spanner} from '../src';
import {MutationSet} from '../src/transaction';
import protobuf = google.spanner.v1;
Expand Down
72 changes: 0 additions & 72 deletions handwritten/spanner/owlbot.py
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions handwritten/spanner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"ycsb": "node ./benchmark/ycsb.js run -P ./benchmark/workloada -p table=usertable -p cloudspanner.instance=ycsb-instance -p operationcount=100 -p cloudspanner.database=ycsb",
"fix": "gts fix",
"clean": "gts clean",
"compile": "tsc -p . && cp -r protos build && cp -r test/data build/test",
"prepare": "npm run compile-protos && npm run compile",
"compile": "tsc -p . && cp -r test/data build/test",
"prepare": "npm run compile",
"pretest": "npm run compile",
"presystem-test": "npm run compile",
"preobservability-test": "npm run compile",
Expand Down Expand Up @@ -88,7 +88,8 @@
"stack-trace": "0.0.10",
"stream-events": "^1.0.5",
"teeny-request": "^10.0.0",
"through2": "^4.0.2"
"through2": "^4.0.2",
"@google-cloud/spanner-api": "^0.2.0"
},
"devDependencies": {
"@grpc/reflection": "^1.0.4",
Expand Down
Loading
Loading