feat(bigtable): split gapic and proto usage from the handwritten library into bigtable-api#8934
Draft
feywind wants to merge 6 commits into
Draft
feat(bigtable): split gapic and proto usage from the handwritten library into bigtable-api#8934feywind wants to merge 6 commits into
feywind wants to merge 6 commits into
Conversation
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to depend on the external @google-cloud/bigtable-api package for API clients and proto definitions, allowing the removal of numerous auto-generated client files, configurations, and shims. Feedback on the changes highlights a critical issue in handwritten/bigtable/src/admin/table.ts where JSON_PROTOS is read as a raw string using fs.readFileSync instead of being parsed as a JSON object, which will cause runtime failures in protobufFromJSON. A suggestion is provided to use require to synchronously load and parse the JSON file directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in the effort to remove OwlBot from the standard repo path. A new package (bigtable-api) takes care of what OwlBot used to do (shuffle in new protos and generated gapic classes).
Internal: b/531788771