tests(bigtable): fix resource leaks in bigtable system tests - #9030
Open
feywind wants to merge 6 commits into
Open
tests(bigtable): fix resource leaks in bigtable system tests#9030feywind wants to merge 6 commits into
feywind wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors Bigtable system tests to optimize resource usage by scaling down cluster nodes and centralizing instance/backup reaping helpers into a shared utility. Feedback focuses on critical issues introduced in these changes, including potential runtime crashes in the reaping helper due to unsafe non-null assertions and label parsing, multiple gRPC connection leaks from unclosed Bigtable clients in test hooks, and a type mismatch where a numeric timestamp is assigned to instance labels instead of a string.
feywind
changed the title
feywind
marked this pull request as ready for review
July 30, 2026 22:01
feywind
enabled auto-merge (squash)
July 30, 2026 22:02
feywind
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to get the handwritten split project finished, I ran into a lot of resource leaks in the bigtable system tests. These ended up being extensive enough changes that I moved them to their own PR (this one).