fix(ci): update git_dir and clean lockfile artifacts in discovery workflow - #9033
Open
quirogas wants to merge 1 commit into
Open
fix(ci): update git_dir and clean lockfile artifacts in discovery workflow#9033quirogas wants to merge 1 commit into
quirogas wants to merge 1 commit into
Conversation
…kflow During the migration of BigQuery into the google-cloud-node monorepo, the discovery workflow was configured with git_dir set to handwritten/bigquery. Additionally, running pnpm install inside handwritten/bigquery generated an untracked pnpm-lock.yaml file that polluted automated PRs, while gts fix formatted handwritten source files as an unintended side-effect. This change updates discovery.yaml by setting git_dir to '.' so code-suggester properly stages modified files relative to the repository root. It updates the PR title and commit message to use chore(bigquery) for release-please component alignment. Finally, it adds a cleanup step that removes temporary pnpm-lock.yaml files—since handwritten packages do not track pnpm lockfiles—and reverts unintended formatting changes to handwritten source files. The workflow syntax was validated against repository monorepo standards to ensure clean staging of generated type definitions.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
discovery.yamlto fix failures on future workflows.chore(bigquery), so release-please component can identify the change correctly.pnpm-lock.yamlfiles and reverts unintended formatting changes to handwritten source files.git_difkey to.to the correct path.