Repository navigation
feat(firestore): add DML stages, literals source, and atomic execution option to Node SDK pipelines #9118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wu-hui
wants to merge
19
commits into
main
Choose a base branch
from
feat-node-dml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,932
−32
Open
feat(firestore): add DML stages, literals source, and atomic execution option to Node SDK pipelines #9118
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8c8c87f
feat(firestore): add DML stages (insert, upsert, delete, update), lit…
wu-hui 18d2516
test(firestore): refine Node SDK DML integration tests for backend ex…
wu-hui 89dc6c6
fix(firestore): align transaction precedence over atomic pipeline exe…
wu-hui 6374829
refactor(firestore): rename documentId to documentIdExpression in sta…
wu-hui 4b96d59
refactor(firestore): rename transforms to additionalFields in upsert …
wu-hui 3c9a10e
test(firestore): expand pipeline DML unit and system test coverage to…
wu-hui a33788b
Merge branch 'main' into feat-node-dml
MarkDuckworth 84ee1de
refactor(firestore): align DML and literals stage overloads with pipe…
MarkDuckworth 451a27e
refactor(firestore): split insert into insert() and insert(options) o…
MarkDuckworth 4d4da50
refactor(firestore): remove deprecated transforms option from UpsertS…
MarkDuckworth 55f8805
refactor(firestore): remove literals from Pipeline, keep it on Pipeli…
MarkDuckworth 66975bf
fix(firestore): throw on FieldValue sentinels in literals stage docum…
MarkDuckworth 276e15f
fix(firestore): allow null values in literals stage validation
MarkDuckworth 91f708c
fix(firestore): auto-wrap nested objects and arrays in literals docum…
MarkDuckworth 83ed77d
docs(firestore): document insert/upsert target documents and the atom…
MarkDuckworth 3d981ac
docs(firestore): clarify DML target documents for inputs without an ID
MarkDuckworth 8fe0f5c
fix(firestore): reject empty collection path in insert and upsert stages
MarkDuckworth b0f0479
docs(firestore): document update stage behavior for missing documents
MarkDuckworth 5cc0892
Merge branch 'main' into feat-node-dml
MarkDuckworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, since it's an existing issue throughout the SDK it seems. This comment applies to multiple APIs throughout the file.
@codeis Javadoc style tagfirestore.d.ts