Repository navigation
feat(firestore): add x-goog-is-transaction routing header - #9657
Open
nikhilchowdary wants to merge 1 commit into
Open
nikhilchowdary wants to merge 1 commit into
nikhilchowdary wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
api: firestore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the x-goog-is-transaction HTTP header to indicate whether an RPC is part of a transaction. The createCallOptions method has been updated to determine this state based on the method name or the presence of transaction options in the request, and corresponding unit tests have been added to verify this behavior. I have no feedback to provide as there are no review comments to address.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
x-goog-is-transactionrouting header in nodejs SDK to differentiatetransactional requests and non-transactional requestsfrom firestore. Having a routing header for transactions helps in routing grpc requests at GFE.