feat: (BigQuery) Add support Remote Function#9177
Merged
Merged
Conversation
bshaffer
reviewed
May 19, 2026
Contributor
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
Is this something we could write a SystemTest for?
Comment on lines
+181
to
+182
| // There is a BigQueryConnection client available in the PHP cloud | ||
| // but decided to create it here manually instead of adding it as a dependency just for testing. |
Contributor
There was a problem hiding this comment.
hmm, I think I would actually prefer to see the BigQueryConnection client used... you can add it as a dev dependency only so it won't cause any issues
Collaborator
Author
There was a problem hiding this comment.
Yeah I also thought about it, I just didn't want to add any dependency at all? But if we agree on adding it as a dev dependency, let's do it.
Hectorhammett
force-pushed
the
remote-functions
branch
from
cccb032 to
cc3f7d2
Compare
bshaffer
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/249153710