fix(bigquery): limit ssl error workaround to insert_rows - #18295
Open
daniel-sanche wants to merge 1 commit into
Open
fix(bigquery): limit ssl error workaround to insert_rows#18295daniel-sanche wants to merge 1 commit into
daniel-sanche wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new default retry configuration specifically for streaming inserts, DEFAULT_INSERT_ROWS_RETRY, which avoids retrying on SSLError (often indicating schema mismatches in streaming inserts). Meanwhile, the standard DEFAULT_RETRY is updated to allow retrying on SSLError for other API calls. The insert_rows_json method is updated to use this new retry configuration by default and to properly handle wrapped RetryError exceptions. Corresponding unit and system tests have been added and updated. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the scope of #17489. Previously, all SSLErrors were marked as non-retryable. Now, this is only the case for insert_rows requests
Fixes #18178