Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces system tests for the Bigtable accelerator daemon lifecycle, including both asynchronous (test_lifecycle_async.py) and auto-generated synchronous (test_lifecycle_autogen.py) test suites. The tests verify daemon reaping, resource reclamation after crashes, and leak prevention. Feedback on the changes highlights that the asynchronous test file uses synchronous time.sleep() calls inside async def methods, which blocks the event loop. It is recommended to import asyncio and replace these with non-blocking await asyncio.sleep() calls.
Comment on lines
+15
to
+20
| import multiprocessing | ||
| import os | ||
| import shutil | ||
| import signal | ||
| import time | ||
| import uuid |
Contributor
There was a problem hiding this comment.
| os.kill(pid, signal.SIGKILL) | ||
| deadline = time.monotonic() + 10.0 | ||
| while _harness.pid_alive(pid) and time.monotonic() < deadline: | ||
| time.sleep(0.05) |
Contributor
| assert not owner.is_alive(), "owner process not reaped after SIGKILL" | ||
| deadline = time.monotonic() + 30.0 | ||
| while _harness.pid_alive(daemon_pid) and time.monotonic() < deadline: | ||
| time.sleep(0.1) |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Cloud Bigtable accelerator daemon lifecycle system tests (
test_lifecycle_async.py,test_lifecycle_autogen.py) verifying subprocess/UDS tempdir reaping, zero process/FD/tempdir leaks across repeated lifecycles, crash teardown, and orphan exit on owner SIGKILL.Part of Stack #18691 (stacked on #18787).