Skip to content

fix(transformers): correctly handle non-iterable and None content types - #3217

Open
adri22235 wants to merge 16 commits into
googleapis:mainfrom
adri22235:fix/transformers-contents-iterable-type
Open

fix(transformers): correctly handle non-iterable and None content types#3217
adri22235 wants to merge 16 commits into
googleapis:mainfrom
adri22235:fix/transformers-contents-iterable-type

Conversation

@adri22235

@adri22235 adri22235 commented Oct 26, 2026

Copy link
Copy Markdown

Summary

Fixes Mypy [arg-type] failure in _transformers.py:477 where contents was converted via list(contents) without handling single content objects (File, Part, Image) or None.

Changes Included

  • Checks for None before conversion.
  • Safely wraps non-iterable single items into a list.
  • Passes all Mypy 3.11 type checks without error.

Verified with Google CLA signed by @adri22235.

adri22235 and others added 15 commits October 4, 2026 12:31
@adri22235
fix(types): set optimal default top_p threshold for nucleus sampling
9622700
@adri22235
ci: add automated verification workflow for default sampling parameters
d9b846f
@adri22235
chore: apply type ignore fixes for mypy validation
d389d40
@adri22235
Merge branch 'ci/verify-top-p-workflow'
7da4825
@adri22235
ci: add automated verification workflow for Gemini 4 support
53993b4
@adri22235
ci: add pillow types and disable valid-type error code for models myp…
4656509 
…y check
@adri22235
chore(release): bump to 2.30.0 with verified top_p 0.95 and clean mypy
6eb2a0a
@adri22235
ci: update automated verification workflow for top_p and sequence types
a829ced
@MarkDaoust @adri22235
feat: expose SpeakerConfig.mode and SpeakerConfigMode in Interactions…
9cfa6ed 
… SDKs

PiperOrigin-RevId: 991923536
@adri22235
fix(types): resolve all mypy errors and remove redundant cast in toke…
c988339 
…nizer loader
@adri22235
fix(tokenizer): ensure bytes return type in local tokenizer loader
3ab37df
@adri22235
feat(userscript): add native top_p 0.95 restorer and automated ci wor…
2dcaeda 
…kflow
@adri22235
ci: remove userscript verification workflow from SDK PR
dea401f
@adri22235
fix(transformers): support tuple and sequence types in t_contents
f023efc
@adri22235
chore: resolve merge conflicts with upstream main in _api_client and …
8cceaeb 
…errors
@Venkaiahbabuneelam Venkaiahbabuneelam self-assigned this Oct 27, 2026
@Venkaiahbabuneelam Venkaiahbabuneelam added the size:XL Code changes > 100 lines label Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Venkaiahbabuneelam Venkaiahbabuneelam

Labels

size:XL Code changes > 100 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adri22235 @Venkaiahbabuneelam @MarkDaoust