Skip to content

Disable progress bars for non-interactive sessions - #182

Draft
Mirochill wants to merge 2 commits into
googlefonts:mainfrom
Mirochill:fix-126-noninteractive-progress
Draft

Mirochill wants to merge 2 commits into
googlefonts:mainfrom
Mirochill:fix-126-noninteractive-progress

Conversation

@Mirochill

Copy link
Copy Markdown

Summary

  • route the shape comparison progress bars through a small helper
  • disable those tqdm bars automatically when stderr is not an interactive terminal
  • add targeted coverage for interactive and non-interactive stderr handling

Fixes #126.

Validation

  • git diff --check
  • git diff --cached --check
  • git diff --check HEAD~1..HEAD
  • Not run locally: test suite

@google-cla

google-cla Bot commented May 25, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Mirochill

Copy link
Copy Markdown
Author

The Google individual CLA has now been submitted and the GitHub CLA check is passing. The exact progress-bar helper passes isolated redirected-stderr, interactive-TTY, missing-isatty and explicit-disable cases. Full supported dependency setup remains blocked locally: the repository protobuf<=3.20.3 requirement conflicts with current font-language metadata dependencies. No repository dependency pins were changed; these isolated checks do not establish a full font-suite pass.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable progress bar with non-interactive terminal

1 participant